fix(cycle): import MOOD_SCORE_VALUES as a value, not under import type#162
Merged
Conversation
The pre-commit eslint --fix merged the newly-added value import into the
existing `import type { CycleFlow, CyclePayload }` from '@nodea/shared',
producing `import type { …, MOOD_SCORE_VALUES, type MoodScore }`. Under
verbatimModuleSyntax a value cannot sit under `import type`, so tsc failed
in CI (the pre-commit hook rewrote the line after the local typecheck ran).
Rewrite as a single value-level import with inline `type` modifiers on the
type-only names — lint-stable (no duplicate import to merge), so the hook
leaves it alone.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pre-commit eslint --fix merged the newly-added value import into the
existing
import type { CycleFlow, CyclePayload }from '@nodea/shared',producing
import type { …, MOOD_SCORE_VALUES, type MoodScore }. UnderverbatimModuleSyntax a value cannot sit under
import type, so tsc failedin CI (the pre-commit hook rewrote the line after the local typecheck ran).
Rewrite as a single value-level import with inline
typemodifiers on thetype-only names — lint-stable (no duplicate import to merge), so the hook
leaves it alone.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com