Skip to content

refactor(custom-engine): extract leaf config package#146

Open
zpzjzj wants to merge 1 commit into
mainfrom
refactor/customengine-leaf
Open

refactor(custom-engine): extract leaf config package#146
zpzjzj wants to merge 1 commit into
mainfrom
refactor/customengine-leaf

Conversation

@zpzjzj

@zpzjzj zpzjzj commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add a dependency-free internal/customengine leaf package for custom-engine config types, template-token grammar, and workspace-relative path checks
  • make internal/config consume the canonical leaf types while retaining compatibility aliases and explicit wrappers for existing callers
  • migrate custom agent transports to the leaf package, removing the internal/agent -> internal/config dependency without changing the YAML contract or runtime behavior

This completes the leaf-package extraction proposed in #50. The shared template-token parser landed earlier in #89; this PR moves that parser to its intended final home together with the remaining shared primitives.

Verification

  • make verify
  • make test
  • go test -race ./internal/customengine ./internal/config ./internal/agent
  • go test -tags e2e -count=1 -v -run '^TestPipeline_CustomEngine_(LocalTransport|HTTPTransport|Validate|RejectsMissingEnvVar)$' ./e2e\n- import-graph assertion confirming internal/agent no longer imports internal/config\n\nCloses Custom Engine: extract template-resolution into a leaf customengine package #50

@zpzjzj zpzjzj requested a review from hittyt as a code owner July 14, 2026 06:51
@zpzjzj zpzjzj requested a review from roark47 July 14, 2026 07:23
@zpzjzj zpzjzj added the chore label Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant