refactor(custom-engine): extract leaf config package#146
Open
zpzjzj wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/customengineleaf package for custom-engine config types, template-token grammar, and workspace-relative path checksinternal/configconsume the canonical leaf types while retaining compatibility aliases and explicit wrappers for existing callersinternal/agent -> internal/configdependency without changing the YAML contract or runtime behaviorThis completes the leaf-package extraction proposed in #50. The shared template-token parser landed earlier in #89; this PR moves that parser to its intended final home together with the remaining shared primitives.
Verification
make verifymake testgo test -race ./internal/customengine ./internal/config ./internal/agentgo test -tags e2e -count=1 -v -run '^TestPipeline_CustomEngine_(LocalTransport|HTTPTransport|Validate|RejectsMissingEnvVar)$' ./e2e\n- import-graph assertion confirminginternal/agentno longer importsinternal/config\n\nCloses Custom Engine: extract template-resolution into a leaf customengine package #50