feat: support chunked prefill#1174
Open
Jonathan-hwx wants to merge 1 commit into
Open
Conversation
Collaborator
AI Code Review - PR #1174Status: LGTM Summary: P0/0 · P1/0 · P2/0 · P3/0 lgtm ready to ci Checklist ✅ (100 items passed)Strengths
|
c0675fb to
96ba8ff
Compare
Collaborator
AI Code Review - PR #1174Status: BLOCKING Summary: P0/0 · P1/1 · P2/0 · P3/0 Blocking IssuesP1
Checklist Violations (2 fail / 52 total)General Principles Checklist
Strengths
|
96ba8ff to
0eaf5ab
Compare
Collaborator
AI Code Review - PR #1174Status: LGTM Summary: P0/0 · P1/0 · P2/0 · P3/0 lgtm ready to ci Checklist ✅ (52 items passed)Strengths
|
0eaf5ab to
efcba9f
Compare
Collaborator
AI Code Review - PR #1174Status: LGTM Summary: P0/0 · P1/0 · P2/0 · P3/0 lgtm ready to ci Checklist ✅ (52 items passed)Strengths
|
Collaborator
|
internal source has been updated, please review the changes! |
efcba9f to
e46805b
Compare
Collaborator
AI Code Review - PR #1174Status: LGTM Summary: P0/0 · P1/0 · P2/0 · P3/0 lgtm ready to ci Checklist ✅ (52 items passed)Strengths
|
Collaborator
|
internal source has been updated, please review the changes! |
2 similar comments
Collaborator
|
internal source has been updated, please review the changes! |
Collaborator
|
internal source has been updated, please review the changes! |
LLLLKKKK
requested changes
Jul 9, 2026
| self.decode_prefill_ratio, | ||
| self.prefill_chunk_size); | ||
| }, | ||
| [](py::tuple t) { |
| const StreamGroups& stream_groups) const { | ||
| std::vector<torch::Tensor> gathered_mm_features; | ||
| std::vector<torch::Tensor> gathered_mm_extra_input; | ||
| auto ctx = createGatherContext(config_, model_input, stream_groups, GatherContextMode::CONTEXT); |
Collaborator
There was a problem hiding this comment.
整体实现在 scheduler 里是不是更科学一点?
e46805b to
afc55a4
Compare
Collaborator
AI Code Review - PR #1174Status: BLOCKING Summary: P0/0 · P1/2 · P2/0 · P3/0 Blocking IssuesP1
Checklist Violations (2 fail / 118 total)General Principles Checklist
Strengths
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary