fix: avoid num_return_sequences prefill batch fanout#1158
Open
Vinkle-hzt wants to merge 1 commit into
Open
Conversation
Collaborator
AI Code Review - PR #1158Status: BLOCKING Summary: P0/0 · P1/0 · P2/1 · P3/0 Non-blocking SuggestionsP2
Checklist Violations (1 fail / 25 total)General Principles Checklist
Strengths
|
LLLLKKKK
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
num_return_sequencesstreams at batch size 1 for the prompt/context execution step, then fan out tonum_return_sequencesat the first sampling step.return_softmax_probsstorage by max batch.Why
For FIFO scheduling,
num_return_sequencesshould not inflate the context/model batch size before the request has produced its first sampled token. The previousGenerateStream::batchSize(0)returnednum_return_sequencesfor non-beam requests, so StreamGroups and model input assembly treated the prompt step as a larger batch even though the prompt only needs one model execution.