fix: remove hardcoded 180s timeout from REVIEW_FILTER_TASK

[kunaaaalcodes]

What I changed

I removed the hidden 180s inner timeout on REVIEW_FILTER_TASK that was
causing context deadline exceeded errors for people using local LLMs.
Now it uses the same global timeout settings (OCR_LLM_TIMEOUT / --timeout)
as every other task — no more, no less.

Files I touched

internal/agent/agent.go

Deleted the if ft.Timeout > 0 { ... } block in executeReviewFilter.
The filter task was the only task wrapping its LLM call in an extra
context.WithTimeout — and that 180s deadline was smaller than the
300s global timeout, so it always fired first.

internal/config/template/task_template.json

Removed "timeout" from all five tasks. They were dead code — only the
filter task's timeout was ever read in production, and now that's gone too.

internal/config/template/template_test.go

Updated the test to expect Timeout == 0 instead of 120.

Tests

ok github.com/open-code-review/open-code-review/internal/agent 4.18s
ok github.com/open-code-review/open-code-review/internal/config/template 0.61s
ok github.com/open-code-review/open-code-review/internal/diff 11.76s

[CLAassistant]

All committers have signed the CLA.

[github-actions]

✅ OpenCodeReview: No comments generated. Looks good to me.

[lizhengfeng101]

Review

The core change is correct and valuable — removing the inner 180s timeout that raced against the global timeout makes behavior consistent and fixes the reported issue for local LLM users.

However, the cleanup is incomplete:

1. Dead code in internal/diff/relocation.go:33-37

RE_LOCATION_TASK's timeout was also removed from the JSON, but relocation.go still has the identical pattern:

if task.Timeout > 0 {
    var cancel context.CancelFunc
    ctx, cancel = context.WithTimeout(ctx, time.Duration(task.Timeout)*time.Second)
    defer cancel()
}

Since all task timeouts are now removed from the template JSON, this is dead code and should be cleaned up for consistency with the agent.go change.

2. (Optional) Struct field residue in internal/config/template/template.go

The Timeout int fields on TaskTemplate (line 57) and LlmConversation (line 217), plus the assignment at line 73, are now effectively unused. If the intent is to fully remove per-task timeouts, these could be cleaned up too — though this can be a follow-up PR.

If the design intent is to preserve the ability for users to set per-task timeouts via custom template files, then the relocation.go code should stay and this should be clarified in the PR description.

---

TL;DR: Please also remove the same timeout block in relocation.go to keep the codebase consistent. Everything else looks good.

[kunaaaalcodes]

Thanks for the thorough review, @lizhengfeng101! I've pushed an additional commit that removes the same timeout block from internal/diff/relocation.go as you suggested. The dead code cleanup is done while keeping the Timeout struct fields intact for anyone using custom template files. Let me know if anything else needs tweaking!

[lizhengfeng101]

LGTM