-
Notifications
You must be signed in to change notification settings - Fork 781
chore(deps): bump the actions group across 1 directory with 10 updates #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,7 +29,7 @@ jobs: | |
| - goos: windows | ||
| goarch: arm64 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@v7 | ||
|
|
||
| - name: Trust workspace | ||
| run: git config --global --replace-all safe.directory '*' | ||
|
|
@@ -51,7 +51,7 @@ jobs: | |
| go build -ldflags "${LD_FLAGS}" -o "${BIN_NAME}" ./cmd/opencodereview | ||
| echo "bin_name=${BIN_NAME}" >> $GITHUB_ENV | ||
|
|
||
| - uses: actions/upload-artifact@v4 | ||
| - uses: actions/upload-artifact@v7 | ||
| with: | ||
| name: binary-${{ matrix.goos }}-${{ matrix.goarch }} | ||
| path: ${{ env.bin_name }} | ||
|
|
@@ -70,7 +70,7 @@ jobs: | |
| - name: Install git | ||
| run: apt-get update && apt-get install -y git | ||
|
|
||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@v7 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
|
|
@@ -135,7 +135,7 @@ jobs: | |
| echo "RELEASE_NOTES_EOF" | ||
| } >> "$GITHUB_OUTPUT" | ||
|
|
||
| - uses: actions/download-artifact@v4 | ||
| - uses: actions/download-artifact@v8 | ||
| with: | ||
| pattern: binary-* | ||
| merge-multiple: true | ||
|
|
@@ -144,15 +144,15 @@ jobs: | |
| run: sha256sum opencodereview-* | sort > sha256sum.txt | ||
|
|
||
| - name: Create GitHub Release | ||
| uses: softprops/action-gh-release@v2 | ||
| uses: softprops/action-gh-release@v3 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Third-party action should be pinned to a full commit SHA. Example: uses: softprops/action-gh-release@<full-commit-sha> # v3 |
||
| with: | ||
| body: ${{ steps.notes.outputs.body }} | ||
| files: | | ||
| opencodereview-* | ||
| sha256sum.txt | ||
|
|
||
| - name: Attest release artifacts | ||
| uses: actions/attest-build-provenance@v2 | ||
| uses: actions/attest-build-provenance@v4 | ||
| with: | ||
| subject-path: | | ||
| opencodereview-* | ||
|
|
@@ -167,15 +167,15 @@ jobs: | |
| permissions: | ||
| contents: read | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@v7 | ||
|
|
||
| - name: Trust workspace | ||
| run: git config --global --replace-all safe.directory '*' | ||
|
|
||
| - name: Install jq | ||
| run: apt-get update && apt-get install -y jq | ||
|
|
||
| - uses: actions/download-artifact@v4 | ||
| - uses: actions/download-artifact@v8 | ||
| with: | ||
| pattern: binary-* | ||
| merge-multiple: true | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential version mismatch between upload-artifact and download-artifact. The build job uploads artifacts using
actions/upload-artifact@v7, but the release and npm-publish jobs download them usingactions/download-artifact@v8. Historically, major version mismatches between upload and download artifact actions have caused failures (e.g., the v3→v4 transition broke cross-version compatibility due to backend storage changes). Please verify thatupload-artifact@v7is compatible withdownload-artifact@v8, or align both to the same major version.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#454 (review)