Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion internal/config/template/template.go
Original file line number Diff line number Diff line change
Expand Up @@ -157,14 +157,17 @@ func resolveLang(lang string) string {
}

// ApplyLanguage injects a language directive into all system-role messages
// across MAIN_TASK, PLAN_TASK (if set), and MEMORY_COMPRESSION_TASK.
// across MAIN_TASK, PLAN_TASK (if set), MEMORY_COMPRESSION_TASK, and REVIEW_FILTER_TASK (if set).
func (t *Template) ApplyLanguage(lang string) {
instruction := "\n\nAlways respond in " + resolveLang(lang) + "."
applyLanguage(&t.MainTask, instruction)
if t.PlanTask != nil {
applyLanguage(t.PlanTask, instruction)
}
applyLanguage(&t.MemoryCompressionTask, instruction)
if t.ReviewFilterTask != nil {
applyLanguage(t.ReviewFilterTask, instruction)
}
}

// ApplyLanguage injects a language directive into all system-role messages
Expand Down
18 changes: 18 additions & 0 deletions internal/config/template/template_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,12 @@ func TestApplyLanguage(t *testing.T) {
if !strings.HasSuffix(tpl.MemoryCompressionTask.Messages[0].Content, suffix) {
t.Errorf("MemoryCompressionTask system message does not end with %q", suffix)
}
if tpl.ReviewFilterTask == nil {
t.Fatal("ReviewFilterTask should be present in default template")
}
if !strings.HasSuffix(tpl.ReviewFilterTask.Messages[0].Content, suffix) {
t.Errorf("ReviewFilterTask system message does not end with %q", suffix)
}
}

func TestApplyLanguage_DefaultEnglish(t *testing.T) {
Expand Down Expand Up @@ -319,6 +325,18 @@ func TestApplyLanguage_SkipsNonSystemMessages(t *testing.T) {
}
}

func TestApplyLanguage_NilReviewFilterTask(t *testing.T) {
// ApplyLanguage should not panic when ReviewFilterTask is nil.
tpl := &Template{
MainTask: LlmConversation{Messages: []ChatMessage{{Role: "system", Content: "sys"}}},
MemoryCompressionTask: LlmConversation{Messages: []ChatMessage{{Role: "system", Content: "compress"}}},
}
tpl.ApplyLanguage("German")
if !strings.Contains(tpl.MainTask.Messages[0].Content, "German") {
t.Error("MainTask should contain language directive")
}
}

func TestResolveLang(t *testing.T) {
if got := resolveLang(""); got != "English" {
t.Errorf("resolveLang(\"\") = %q, want \"English\"", got)
Expand Down
Loading