feat: Support compile neug.dll on Windows - #786
Open
lnfjpt wants to merge 19 commits into
Open
Conversation
lnfjpt
changed the title
lnfjpt
changed the title
| #include <string> | ||
| #include <unordered_map> | ||
| #include <vector> | ||
| #include "neug/utils/api.h" |
| #include <cstdint> | ||
|
|
||
| // Windows headers may define NONE as a macro; undefine it. | ||
| #ifdef NONE |
Member
There was a problem hiding this comment.
What about rename our NONE? rather than override windows header?
liulx20
reviewed
Jul 30, 2026
| @@ -61,12 +65,16 @@ namespace neug { | |||
| /// Util functions. | |||
|
|
|||
| inline void blockSignal(int sig) { | |||
liulx20
reviewed
Jul 30, 2026
| # It must be PUBLIC, otherwise there will be performance differences. | ||
| target_link_libraries(neug PUBLIC mimalloc) | ||
| if(WIN32) | ||
| target_link_libraries(neug PUBLIC mimalloc-static) |
liulx20
reviewed
Jul 30, 2026
| #include <errno.h> | ||
| #include <stdint.h> | ||
| #ifndef _WIN32 | ||
| #include <unistd.h> |
lnfjpt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #744, #769