Skip to content

fix: correct clang-format include ordering in reorganized utils/io headers - #641

Draft
luoxiaojian with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-check-format-job
Draft

fix: correct clang-format include ordering in reorganized utils/io headers#641
luoxiaojian with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-check-format-job

Conversation

Copilot AI commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

PR #640 reorganized utils IO headers under neug/utils/io/ but left several #include directives out of alphabetical order, causing the check-format CI job to fail.

Changes

  • Reordered #include statements in 12 header files to satisfy clang-format 10.0.1 alphabetical ordering requirements:
    • extension/httpfs/include/{http,s3}_filesystem.h
    • include/neug/compiler/function/{read_function,export/json_export_function,import/{csv,json}_read_function}.h
    • include/neug/storages/loader/loader_utils.h
    • include/neug/utils/io/{read/common/options,read/csv/csv_reader,read/json/json_reader,write/writer}.h
    • tests/utils/test_reader.h
  • Reflowed long function signatures in csv_reader.h and json_reader.h to fit within the column limit

Example of a typical fix:

// Before (wrong order)
#include "neug/utils/io/vfs/file_system.h"
#include "neug/utils/io/read/common/schema.h"

// After (alphabetical)
#include "neug/utils/io/read/common/schema.h"
#include "neug/utils/io/vfs/file_system.h"

@CLAassistant

CLAassistant commented Jun 29, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ luoxiaojian
❌ Copilot
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI changed the title [WIP] Fix failing GitHub Actions job check-format fix: correct clang-format include ordering in reorganized utils/io headers Jun 29, 2026
Copilot AI requested a review from luoxiaojian June 29, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants