style(sight): fix all clippy warnings with -D warnings#922
Merged
Conversation
Apply cargo clippy --fix for machine-applicable lints (format! inlining, redundant closures, useless conversions). Add # Safety docs to 13 FFI functions. Fix manual strip_prefix in config.rs. Remaining architectural lints (type_complexity, too_many_arguments, large_enum_variant, unnecessary_cast) allowed at crate level with TODO comments for future refactoring. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
chengshuyi
approved these changes
Jun 15, 2026
jfeng18
added a commit
to jfeng18/anolisa
that referenced
this pull request
Jun 15, 2026
Add cargo fmt --all --check and cargo clippy -D warnings steps to the test-agentsight CI job, alongside the existing coverage gate. Also fix clippy warnings on new FFI functions added after the alibaba#922 cleanup. Completes the Harness roadmap P0 "CI fmt + clippy" alongside the coverage gate from the initial commit. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jfeng18
added a commit
to jfeng18/anolisa
that referenced
this pull request
Jun 15, 2026
Add cargo fmt --all --check and cargo clippy -D warnings steps to the test-agentsight CI job, alongside the existing coverage gate. Also fix clippy warnings on new FFI functions added after the alibaba#922 cleanup. Completes the Harness roadmap P0 "CI fmt + clippy" alongside the coverage gate from the initial commit. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
chengshuyi
pushed a commit
that referenced
this pull request
Jun 15, 2026
Add cargo fmt --all --check and cargo clippy -D warnings steps to the test-agentsight CI job, alongside the existing coverage gate. Also fix clippy warnings on new FFI functions added after the #922 cleanup. Completes the Harness roadmap P0 "CI fmt + clippy" alongside the coverage gate from the initial commit. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Ziqi002
pushed a commit
to Ziqi002/anolisa
that referenced
this pull request
Jun 18, 2026
Add cargo fmt --all --check and cargo clippy -D warnings steps to the test-agentsight CI job, alongside the existing coverage gate. Also fix clippy warnings on new FFI functions added after the alibaba#922 cleanup. Completes the Harness roadmap P0 "CI fmt + clippy" alongside the coverage gate from the initial commit. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
casparant
pushed a commit
to casparant/anolisa
that referenced
this pull request
Jun 18, 2026
Add cargo fmt --all --check and cargo clippy -D warnings steps to the test-agentsight CI job, alongside the existing coverage gate. Also fix clippy warnings on new FFI functions added after the alibaba#922 cleanup. Completes the Harness roadmap P0 "CI fmt + clippy" alongside the coverage gate from the initial commit. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix all clippy warnings so
cargo clippy --all-targets -- -D warningspasses clean. This is step 2 of 3 for the Harness roadmap P0 "CI fmt + clippy":fmt --check+clippy -D warnings)What changed
Auto-fixed (machine-applicable):
uninlined_format_args(format string inlining)Hand-fixed:
# Safetydoc sectionsconfig.rs:s[1..]→s.strip_prefix(':').unwrap()(manual_strip)genai.rs:_toolsprefix for intentionally unused bindingAllowed (require architectural changes):
type_complexity,too_many_arguments,large_enum_variant,doc_lazy_continuation,doc_overindented_list_items,unnecessary_castptr_arg,should_implement_trait,field_reassign_with_default,needless_range_loop,same_item_push,vec_init_then_pushEach allow has a clear reason; architectural lints (type_complexity, too_many_arguments) are tracked for future refactoring.
Test plan
cargo clippy --all-targets -- -D warningspasses (0 errors)cargo fmt --checkpasses (0 diffs)🤖 Generated with Claude Code