fix(sec-core): skill-ledger managed-root retry for unmanaged skills#1408
Open
zhangtaibo wants to merge 1 commit into
Open
fix(sec-core): skill-ledger managed-root retry for unmanaged skills#1408zhangtaibo wants to merge 1 commit into
zhangtaibo wants to merge 1 commit into
Conversation
|
云孟 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: agent-sec-core skill-ledger unmanaged skill warning
Fixes #1406
Problem
The Hermes plugin's
SkillLedgerCapability._on_pre_tool_callcallsagent-sec-cli skill-ledger show <skill_dir>to check skill security status. When a skill is in~/.hermes/skills/but the skill-ledger daemon only manages/usr/share/anolisa/skills/*, the CLI returnslatestStatus: "unmanaged"withmessage: null.The plugin's code:
Since
messageisnullfor unmanaged skills, the plugin returnsNonewithout generating any warning — even though the skill may have been scanned/certified in a managed root and copied to~/.hermes/skills/.This causes 4
TestHermesSkillLedgertest cases to fail continuously (5 consecutive days 07-05~07-09):test_none_skill_shows_warningtest_deny_skill_shows_warningtest_drifted_skill_shows_warningtest_tampered_skill_shows_warningFix
When
latestStatus == "unmanaged", retry the query against managed skill roots (/usr/share/anolisa/skills/,/usr/local/share/anolisa/skills/). If a managed copy exists with a real status, use that result instead.If no managed copy is found, generate a synthetic warning:
"unmanaged — not tracked by Skill Ledger. Security status unknown."so the user is alerted that the skill has no ledger attestation.Verification
git apply patch+bash scripts/rpm-build.sh agent-sec-core→ exit 0agent-sec-cli-0.7.1-1.alnx4.x86_64.rpm(207M),agent-sec-hermes-hook-0.7.1-1.alnx4.x86_64.rpm(36K), etc./usr/share/anolisa/skills/<name>when~/.hermes/skills/<name>is unmanagedTest Cases
tests/test_hermes_intercept_tmux.py::TestHermesSkillLedger::test_none_skill_shows_warningtests/test_hermes_intercept_tmux.py::TestHermesSkillLedger::test_deny_skill_shows_warningtests/test_hermes_intercept_tmux.py::TestHermesSkillLedger::test_drifted_skill_shows_warningtests/test_hermes_intercept_tmux.py::TestHermesSkillLedger::test_tampered_skill_shows_warning