Skip to content

feat(sec-core): add sensitive_file_paths in code scanner rules #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yangdao479 wants to merge 1 commit into
base: main
Choose a base branch
from
+130 −0
Open

feat(sec-core): add sensitive_file_paths in code scanner rules #1401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/agent-sec-core/agent-sec-cli/src/agent_sec_cli/code_scanner/rules/bash/_shared.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,16 @@ sensitive_file_paths:
- ~/\.zsh_history
- /etc/kubernetes/
- kubeconfig
# Agent runtime credential and auth state files.
- ~/\.codex/auth\.json\b
- ~/\.hermes/auth\.json\b
- ~/\.hermes/\.env\b
- ~/\.hermes/config\.yaml\b
- ~/\.hermes/profiles/[^/]+/auth\.json\b
- ~/\.hermes/profiles/[^/]+/\.env\b
- ~/\.hermes/profiles/[^/]+/config\.yaml\b
- ~/\.openclaw/openclaw\.json\b
- ~/\.openclaw/agents/[^/]+/agent/models\.json\b
- ~/\.copilot-shell/settings\.json\b
- ~/\.copilot-shell/aliyun_creds\.json\b
- ~/\.copilot-shell/mcp-oauth-tokens(-v2)?\.json\b
13 changes: 13 additions & 0 deletions src/agent-sec-core/agent-sec-cli/src/agent_sec_cli/code_scanner/rules/python/_shared.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,16 @@ sensitive_file_paths:
- /boot/
- /usr/lib/systemd/
- /etc/systemd/system/
# Agent runtime credential and auth state files.
- ~/\.codex/auth\.json\b
- ~/\.hermes/auth\.json\b
- ~/\.hermes/\.env\b
- ~/\.hermes/config\.yaml\b
- ~/\.hermes/profiles/[^/]+/auth\.json\b
- ~/\.hermes/profiles/[^/]+/\.env\b
- ~/\.hermes/profiles/[^/]+/config\.yaml\b
- ~/\.openclaw/openclaw\.json\b
- ~/\.openclaw/agents/[^/]+/agent/models\.json\b
- ~/\.copilot-shell/settings\.json\b
- ~/\.copilot-shell/aliyun_creds\.json\b
- ~/\.copilot-shell/mcp-oauth-tokens(-v2)?\.json\b
104 changes: 104 additions & 0 deletions src/agent-sec-core/tests/unit-test/code_scanner/testdata/scan_test_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,63 @@
("cat /etc/crontab", "bash", "shell-read-sensitive-file", 1),
("cat /var/spool/cron/root", "bash", "shell-read-sensitive-file", 1),
("cat /etc/hostname", "bash", "shell-read-sensitive-file", 1),
# --- TP: Agent runtime credentials and auth state ---
("cat ~/.codex/auth.json", "bash", "shell-read-sensitive-file", 1),
("cat ~/.hermes/auth.json", "bash", "shell-read-sensitive-file", 1),
("cat ~/.hermes/.env", "bash", "shell-read-sensitive-file", 1),
("cat ~/.hermes/config.yaml", "bash", "shell-read-sensitive-file", 1),
("cat ~/.hermes/profiles/coder/auth.json", "bash", "shell-read-sensitive-file", 1),
("cat ~/.hermes/profiles/coder/.env", "bash", "shell-read-sensitive-file", 1),
(
"cat ~/.hermes/profiles/coder/config.yaml",
"bash",
"shell-read-sensitive-file",
1,
),
("cat ~/.openclaw/openclaw.json", "bash", "shell-read-sensitive-file", 1),
(
"cat ~/.openclaw/agents/main/agent/models.json",
"bash",
"shell-read-sensitive-file",
1,
),
("cat ~/.copilot-shell/settings.json", "bash", "shell-read-sensitive-file", 1),
("cat ~/.copilot-shell/aliyun_creds.json", "bash", "shell-read-sensitive-file", 1),
(
"cat ~/.copilot-shell/mcp-oauth-tokens.json",
"bash",
"shell-read-sensitive-file",
1,
),
(
"cat ~/.copilot-shell/mcp-oauth-tokens-v2.json",
"bash",
"shell-read-sensitive-file",
1,
),
# === True Negatives ===
("cat /var/log/syslog", "bash", "shell-read-sensitive-file", 0),
("less /tmp/output.txt", "bash", "shell-read-sensitive-file", 0),
("head -n 5 README.md", "bash", "shell-read-sensitive-file", 0),
("echo /etc/shadow", "bash", "shell-read-sensitive-file", 0),
("ls -la /etc/shadow", "bash", "shell-read-sensitive-file", 0),
# --- TN: Agent diagnostics and non-credential files ---
("hermes doctor", "bash", "shell-read-sensitive-file", 0),
("openclaw doctor --fix", "bash", "shell-read-sensitive-file", 0),
("cat ~/.codex/skills/example/SKILL.md", "bash", "shell-read-sensitive-file", 0),
("cat ~/.codex/tmp/session-note.txt", "bash", "shell-read-sensitive-file", 0),
("cat ~/.hermes/logs/agent.log", "bash", "shell-read-sensitive-file", 0),
("cat ~/.hermes/skills/demo/SKILL.md", "bash", "shell-read-sensitive-file", 0),
("cat ~/.openclaw/skills/demo/SKILL.md", "bash", "shell-read-sensitive-file", 0),
("cat ~/.openclaw/workspace/SOUL.md", "bash", "shell-read-sensitive-file", 0),
("cat ~/.copilot-shell/commands/demo.md", "bash", "shell-read-sensitive-file", 0),
(
"cat ~/.copilot-shell/history/session.jsonl",
"bash",
"shell-read-sensitive-file",
0,
),
("cat ~/.copilot-shell/memory.md", "bash", "shell-read-sensitive-file", 0),
# --- cross-command isolation ---
("cat file.txt; echo /etc/shadow", "bash", "shell-read-sensitive-file", 0),
("cat file.txt | grep /etc/shadow", "bash", "shell-read-sensitive-file", 0),
Expand Down Expand Up @@ -791,6 +842,45 @@
("f = open('~/.ssh/id_rsa', 'r')", "python", "py-sensitive-file-access", 1),
("open('/etc/sudoers', 'w')", "python", "py-sensitive-file-access", 1),
("open('.env', 'r')", "python", "py-sensitive-file-access", 1),
# === TP: Agent runtime credentials and auth state ===
("open('~/.codex/auth.json').read()", "python", "py-sensitive-file-access", 1),
("Path('~/.hermes/.env').read_text()", "python", "py-sensitive-file-access", 1),
(
"Path('~/.hermes/config.yaml').read_text()",
"python",
"py-sensitive-file-access",
1,
),
(
"open('~/.hermes/profiles/coder/auth.json')",
"python",
"py-sensitive-file-access",
1,
),
(
"Path('~/.hermes/profiles/coder/config.yaml').read_text()",
"python",
"py-sensitive-file-access",
1,
),
(
"Path('~/.openclaw/openclaw.json').read_text()",
"python",
"py-sensitive-file-access",
1,
),
(
"Path('~/.openclaw/agents/main/agent/models.json').read_text()",
"python",
"py-sensitive-file-access",
1,
),
(
"open('~/.copilot-shell/mcp-oauth-tokens-v2.json').read()",
"python",
"py-sensitive-file-access",
1,
),
# === TP: pathlib + sensitive path ===
("Path('/etc/shadow').read_text()", "python", "py-sensitive-file-access", 1),
(
Expand Down Expand Up @@ -850,6 +940,20 @@
0,
),
("Path('output.txt').read_text()", "python", "py-sensitive-file-access", 0),
# === TN: Agent runtime non-credential files ===
("open('~/.codex/tmp/session-note.txt')", "python", "py-sensitive-file-access", 0),
(
"Path('~/.hermes/logs/agent.log').read_text()",
"python",
"py-sensitive-file-access",
0,
),
(
"Path('~/.copilot-shell/history/session.jsonl').read_text()",
"python",
"py-sensitive-file-access",
0,
),
# --- cross-line isolation ---
(
"open('regular.txt')\nprint('/etc/shadow')",
Expand Down
Loading