use arrays for operationIndex() to resolve array_merge TypeError#367
Open
vrodriguero wants to merge 1 commit into
Open
use arrays for operationIndex() to resolve array_merge TypeError#367vrodriguero wants to merge 1 commit into
vrodriguero wants to merge 1 commit into
Conversation
- Replaced both operationIndex() calls with plain arrays - Updated the tests
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
Replaced both
operationIndex()calls with plainarrays, which matches the client's expected input format.What problem is this fixing?
ReImportCommandpassedOperationIndexParamsmodel objects toSearchClient::operationIndex(), but the generated client internally callsarray_merge()on that argument, causing aTypeErrorat runtime.Although the client still claims to accept
OperationIndexParams, that path is broken. The proposed fix resolves the issue with the reimport. I will open an issue with the Algolia client too.