fix INF and NaN errors#360
Open
mitchierichie wants to merge 1 commit into
Open
Conversation
|
Thanks for fixing this |
Author
Hopefully it gets merged!!! 🥳 |
DevinCodes
requested changes
Jun 4, 2025
DevinCodes
left a comment
DevinCodes
left a comment
Contributor
There was a problem hiding this comment.
Hey @mitchierichie ,
Thank you for the PR. Would you mind adding a quick unit test for this behaviour, please?
Author
|
will do @DevinCodes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
Check if a string that was cast to a number is NaN or INF and don't store it in the transformed array.
What problem is this fixing?
Converting all numeric strings, is causing errors when a numeric string casts as a float to
INForNaN. This causes this package to crash the app. These attributes should just be left as strings.Here's an example: