Commit operations improvements#15
Open
eduardocampano wants to merge 10 commits into
Open
Conversation
There was a problem hiding this comment.
We also need to put commit_sync=True, right?
Author
There was a problem hiding this comment.
Correct, I also removed the parameter from the commit calls from the tests
from other doc managers, as defaults are defined elsewhere and passed in
Member
|
Hi @eduardocampano, Sorry for the delay, I missed the pull request and it takes me some time to test it. I tested the code and I spotted some bug in the connector itself and in our python client. I just have one question, why you didn't keep the default parameter names in the constructor? With this change, it's not anymore possible to set it from the command line. Thanks a lot for improvement of the connector I love it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
self.run_auto_commit()in constructorBATCH_SIZEandAUTO_COMMIT_DELAY_Sto have the same constructor parameters as other doc managers.commit_syncto use synchronous commits to algolia with aFalsedefault valuecommit_waittask_intervalwith default value1(second) to reduce the number ofwaitTaskrequests (previously was 100ms,waitTaskdefault value)