-
Notifications
You must be signed in to change notification settings - Fork 551
chore(lint): add import linting and prettier formatting locally #6981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shaejaz
wants to merge
17
commits into
master
Choose a base branch
from
chore/import-lint-local
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
600d4ab
add eslint config
shaejaz 21fcf8d
update formatting ci
shaejaz ba59f56
reset script
shaejaz ea2302d
format code
shaejaz 875f1eb
fix codacy
shaejaz baeb3e7
fix lint
shaejaz 6c06221
Merge branch 'master' into chore/import-lint-local
shaejaz 55e2d31
fix formatting
shaejaz 2960b4b
chore: drop eslint + prettier, switch formatting to oxfmt
shaejaz 3e2abd4
chore: reformat repo with oxfmt
shaejaz 52cc77f
chore: ignore oxfmt reformat commit in git blame
shaejaz 1e7dfcd
chore: update CI + docs for oxfmt
shaejaz 5fdf089
chore: apply oxlint --fix and reformat after import reorder
shaejaz 39db1fd
Merge branch 'master' into chore/import-lint-local
shaejaz 3806223
merge
shaejaz 35cfe2b
fix lint
shaejaz e14c6b1
Merge branch 'master' into chore/import-lint-local
shaejaz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| interface: | ||
| display_name: "Port InstantSearch Widget" | ||
| short_description: "Port widgets across InstantSearch flavors" | ||
| default_prompt: "Use $port-widget to port a widget or connector-driven feature across the InstantSearch JavaScript, React, and Vue packages in this repo." | ||
| display_name: 'Port InstantSearch Widget' | ||
| short_description: 'Port widgets across InstantSearch flavors' | ||
| default_prompt: 'Use $port-widget to port a widget or connector-driven feature across the InstantSearch JavaScript, React, and Vue packages in this repo.' | ||
|
|
||
| policy: | ||
| allow_implicit_invocation: true |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,5 @@ | ||
| # Introduced prettier | ||
| 25cd787e6a06502ee3a85648f90f693276cca671 | ||
|
|
||
| # Reformat with oxfmt | ||
| 3e2abd41c28a6dec768ac7a2c3b531300d8bc62e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,7 +39,6 @@ scripts/*/CHANGELOG.md | |
| .vscode/ | ||
|
|
||
| # Caches | ||
| .eslintcache | ||
| .parcel-cache | ||
| .nuxt | ||
|
|
||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The numbered instructions here were collapsed in a way that hurts clarity and changes meaning (e.g., the
check:linkscommand and its explanation are merged into one bullet, and5. ## REQUIRED:is an odd hybrid of list item + heading). Please reformat these steps back into clear bullets/lines so the automation prompt remains unambiguous.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was reformatted because of the --- being a header