Open in Finder via NSWorkspace instead of sandboxed /usr/bin/open#22
Merged
Conversation
The "Open in Finder" button shelled out to /usr/bin/open, which does nothing from a sandboxed app: the spawned tool inherits the sandbox and its LaunchServices request to open a path outside the container is silently denied (no kernel sandbox violation, no effect). Open the user-visible File Provider URL with NSWorkspace from the app process instead, holding security-scoped access (the URL is security-scoped), and fall back to revealing the item if opening the folder fails. Logs each outcome so the path is diagnosable.
Nightly BuildDownload Findle Nightly (unsigned) Built from b84b5c8. Important This build is unsigned. macOS will block it on first launch. To open it:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The in-app "Open in Finder" / "Reveal in Finder" button did nothing. It shelled out to
/usr/bin/open, which fails from a sandboxed app: the spawned tool inherits the app sandbox and its LaunchServices request to open a path outside the container is silently denied — no kernel sandbox violation, no effect (confirmed: live captures during clicks showed noopenprocess effect and no denial).Fix
Open the user-visible File Provider URL with
NSWorkspacefrom the app process, holding security-scoped access (the URL fromgetUserVisibleURLis security-scoped). Falls back toactivateFileViewerSelecting(reveal) if opening the folder fails, and logs each outcome so it's diagnosable.Build
Compiles clean, no deprecation warnings. (Core sync + Finder population already work on build 34; this is the remaining convenience button.)