Skip to content

Made changes to account for the deno v2.8 release#102

Merged
alexanderharding merged 2 commits into
mainfrom
deno-2.8
May 24, 2026
Merged

Made changes to account for the deno v2.8 release#102
alexanderharding merged 2 commits into
mainfrom
deno-2.8

Conversation

@alexanderharding

@alexanderharding alexanderharding commented May 24, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Chores

    • Updated project configuration formatting and package import resolution; added linting rules to prevent use of process- and Node-global APIs.
  • Tests

    • Enabled stricter test sanitization for operations and resources to improve test isolation and reliability.

Review Change Stack

@alexanderharding alexanderharding self-assigned this May 24, 2026
@coderabbitai

coderabbitai Bot commented May 24, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 315a9fa2-dbfc-428e-9556-32b5af48d3d3

📥 Commits

Reviewing files that changed from the base of the PR and between d332064 and 950b68e.

⛔ Files ignored due to path filters (1)
  • deno.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • deno.json

📝 Walkthrough

Walkthrough

deno.json is compacted (tasks, fmt, imports), the @std/assert import is unpinned, lint.rules enables no-process-global and no-node-globals, and test sanitization is enabled via test.sanitizeOps and test.sanitizeResources.

Changes

Configuration enforcement and testing

Layer / File(s) Summary
Configuration updates
deno.json
tasks, fmt, and imports are reformatted into compact single-line objects; the @std/assert import is changed to jsr:@std/assert`` (unpinned); lint.rules enables `no-process-global` and `no-node-globals`; `test.sanitizeOps` and `test.sanitizeResources` are set to `true`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A tidy file, no pins to chase,
Rules block globals from the place.
Tests scrubbed clean, no stray resource,
The rabbit hops—config on course. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is vague and generic, referring to a version release without specifying what actual changes were made or their purpose. Provide a more specific title describing the actual changes, such as 'Update deno.json configuration for v2.8 compatibility' or 'Add linting rules and test sanitization to deno.json'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch deno-2.8

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@deno.json`:
- Line 59: The import pin for `@std/assert` is locked to jsr:`@std/assert`@^1.0.17;
update the import key in deno.json (the "imports" entry for "`@std/assert`") to
use the unpinned JSR form "jsr:`@std/assert`" (or alternatively bump the semver
range to include 1.0.19+) so the project resolves the recommended Deno
v2.8-compatible version.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f1ac6f84-b231-4742-8b39-eeae1b74aece

📥 Commits

Reviewing files that changed from the base of the PR and between 7e3571d and d332064.

📒 Files selected for processing (1)
  • deno.json

Comment thread deno.json Outdated
@alexanderharding alexanderharding merged commit 1cb80ee into main May 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant