Skip to content

ci: add PR workflow with lint CI, agent instructions, and install diagnostics#1

Open
alex-bezek wants to merge 1 commit into
masterfrom
ci/pr-workflow
Open

ci: add PR workflow with lint CI, agent instructions, and install diagnostics#1
alex-bezek wants to merge 1 commit into
masterfrom
ci/pr-workflow

Conversation

@alex-bezek

Copy link
Copy Markdown
Owner

Summary

Implements M1 of the AI-driven workflow vision (plans/002-vision.md):

  • AGENTS.md — cross-agent workflow rules: always branch, conventional commits, gh pr create
  • .github/copilot-instructions.md — Copilot context + review sensitivity calibration for personal dotfiles (default stance: approve unless critical issue)
  • scripts/ci/lint.sh — deterministic gate: shellcheck, bash -n, jq empty on all JSON (18 files checked)
  • .github/workflows/ci.yml — single lint job, runs on all PRs and pushes to master
  • scripts/dotfiles-debug.sh — portable diagnostics (OS, tools, symlinks, disk, cloud-init)
  • install.sh — trap writes $HOME/.dotfiles-status on success/failure, auto-runs debug on crash
  • README.md — notes the repo now uses PR workflow
  • Shellcheck fixes across existing scripts (inline disables for false positives)

What's next

After this PR merges:

  1. Configure GitHub branch protection (see plans/002-manual-steps.md steps 6-9)
  2. PR M1 Checkpoint: Manual steps needed after PR #1 merges #2 adds git/hooks/pre-push to block direct pushes to master
  3. PR M1 Checkpoint: Manual steps needed after PR #1 merges #2 validates the full CI + Copilot review loop end-to-end

Test plan

  • bash scripts/ci/lint.sh passes locally (18 files, all clean)
  • bash -n install.sh passes
  • bash scripts/dotfiles-debug.sh runs cleanly on macOS
  • CI lint job passes on this PR
  • Copilot review is requested (if ruleset configured)

Full spec: plans/002-pr-workflow-and-ci.md

…gnostics

Implements M1 of the AI-driven workflow vision (plans/002-vision.md):
- AGENTS.md: cross-agent workflow rules (branch, PR, conventions)
- .github/copilot-instructions.md: Copilot review calibration for dotfiles
- scripts/ci/lint.sh: shellcheck + bash syntax + JSON validation
- .github/workflows/ci.yml: GitHub Actions lint gate
- scripts/dotfiles-debug.sh: portable install diagnostics
- install.sh: trap writes $HOME/.dotfiles-status on success/failure
- README.md: note about PR-based workflow
- Shellcheck fixes across existing scripts (inline disables for false positives)

Spec: plans/002-pr-workflow-and-ci.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant