fix(console): make use_canvas exception-safe (C2)#37
Merged
dsent merged 2 commits intoJun 30, 2026
Conversation
aldum
requested changes
Jun 30, 2026
aldum
left a comment
aldum
left a comment
Owner
There was a problem hiding this comment.
I know I was the one who left it off, but let's indicate the return type on the method
aldum
approved these changes
Jun 30, 2026
Author
|
Good catch — added the @return annotation (any ..., since it forwards f()'s values). Pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use_canvas bound the offscreen canvas, called f(), then restored with gfx.setCanvas(). If f() threw, the restore was skipped and all later rendering went to the offscreen canvas. Run f() under pcall, always restore the canvas, then re-raise on failure and return f()'s values on success. Error propagation and return values are preserved; only the cleanup is now guaranteed.