Skip to content

fix(os): popen handle leak and exit-code parse crash (B4, A8) #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsent merged 1 commit into from
Jun 30, 2026
Merged

fix(os): popen handle leak and exit-code parse crash (B4, A8) #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/util/os.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ end

--- @return boolean success
local function test_popen()
local ok = pcall(io.popen, 'echo')
local ok, handle = pcall(io.popen, 'echo')
if ok and handle then handle:close() end
return ok
end

Expand Down Expand Up @@ -46,10 +47,11 @@ local function runcmd_with_exit(cmd)
if handle then
local result = handle:read("*a")
handle:close()
local _, _, exit_code = result:find("(%d+)%s*$")
result = result:sub(1,
result:find("(%d+)%s*$") - 1):gsub("%s+$", ""
)
local s, _, exit_code = result:find("(%d+)%s*$")
if not s then
return false, result
end
result = result:sub(1, s - 1):gsub("%s+$", "")
exit_code = tonumber(exit_code)
if exit_code ~= 0 then
return false, result
Expand Down
Loading