Add micro:bit built-in sounds to the audio library#21
Merged
Conversation
Collaborator
|
Worth noting that step.ogg, chirp.ogg and powerup.ogg are not from the micro:bit default library (but we need them anyway). |
aldum
approved these changes
Jun 5, 2026
nagydani
approved these changes
Jun 5, 2026
nagydani
left a comment
There was a problem hiding this comment.
The supplied sound effects are all good and useful. The only remark is that "step" is quite similar to the already existing "toggle", but as it is extremely short, that is acceptable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 13 micro:bit built-in sound effects to compy.audio, alongside the existing effects in assets/sounds/.
New keys: chirp, powerup, step, and ubit_giggle / ubit_happy / ubit_hello / ubit_mysterious / ubit_sad / ubit_slide / ubit_soaring / ubit_spring / ubit_twinkle / ubit_yawn.