Split monster block#16
Merged
Merged
Conversation
aldum
marked this pull request as draft
May 18, 2026 17:30
As part of submit preprocesing, enforce newlines between non-empty pretty blocks if there is more than one block
only partial saving, oveesized blocks are ephemeral
introduce test helpers
All context variables need hard resets before each test (sharing controller object without cleanup -> cursor chaos)
3 tests still failing
Conservatively setting col=65 to match editor's own conventions
(get_size -> get_max_size)
aldum
force-pushed
the
feature/monsterblock
branch
from
May 19, 2026 19:34
46069d3 to
54f0841
Compare
aldum
marked this pull request as ready for review
May 22, 2026 20:32
hleb-rubanau
approved these changes
May 25, 2026
hleb-rubanau
left a comment
hleb-rubanau
left a comment
Collaborator
There was a problem hiding this comment.
This PR is a copy of #11 with comments adjusted to enforce more standartization of conventional commits types.
Codewise its the same, tests are passing. IMO its ready to be merged.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.