Greedy Geographical Routing Module#47
Open
satyatumati wants to merge 2 commits into
Open
Conversation
akeranen
requested changes
Apr 17, 2017
Owner
akeranen
left a comment
akeranen
left a comment
There was a problem hiding this comment.
Instead of extending the core classes, I'd suggest implementing functionality in the routing module and reusing the property mechanism of Message class.
| public int compareTo(DTNHost h) { | ||
| return this.getAddress() - h.getAddress(); | ||
| } | ||
| /** |
Owner
There was a problem hiding this comment.
This feature does not sound to me generic enough for the DTNHost class. Perhaps it's better implemented in the routing module.
| /** | ||
| * @return the msgType | ||
| */ | ||
| public int getMsgType(){ |
Owner
There was a problem hiding this comment.
Since this is quite specific to a routing module, I'd suggest using the {add,get,update}Property methods for this kind of functionality.
| /** | ||
| * @return the localHops | ||
| */ | ||
| public int getLocalHops(){ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added the GreedyGeoRouter module to the src.