Harden assimilate.sh: arch-aware delta, quoted $HOME, perms#18
Open
akan72 wants to merge 1 commit into
Open
Conversation
- delta install: detect arch with uname -m. Apple Silicon uses the pinned aarch64-apple-darwin tarball; Intel Macs fall back to 'brew install git-delta' (delta ships no x86_64-apple-darwin build, so there's no pinned tarball to verify) - bash_profile: quote $HOME in the .bashrc test/source (handles paths with spaces) - chmod 600 ~/.gitconfig and chmod 700 ~/.ssh (when present) after symlinking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Branch 6: harden
assimilate.shandbash_profile.uname -m. Apple Silicon uses the pinnedaarch64-apple-darwintarball; Intel Macs fall back tobrew install git-delta.$HOMEinbash_profile:if [ -f "$HOME/.bashrc" ]chmod 600 ~/.gitconfigandchmod 700 ~/.ssh(when present) after symlinkingWhy & alternatives (from explanations.txt — Branch 6)
aarch64-apple-darwinwas hardcoded — breaks on Intel Macs.brew install git-delta(the pinned approach exists due to brew bottle ABI drift).$HOMEin bash_profile[ -f $HOME/.bashrc ]breaks on paths with spaces. Defensive.chmod 600on sensitive symlinks