Skip to content

CLAUDE.md: prescribe make check as pre-push gate #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ak2k merged 1 commit into from
May 17, 2026
Merged

CLAUDE.md: prescribe make check as pre-push gate #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,13 @@ Our fixtures are the de facto spec.

- **Install**: `uv venv && uv pip install -e .`
- **Test**: `pytest tests/` (golden-file regression net, <0.1s)
- **Smoke a live search**: `flight fare JFK LHR --dep 2026-08-15 --return 2026-08-22 -n 2`
- **Pre-push gate**: `make check` — runs `ruff check`, `ruff format --check`,
`basedpyright src tests`, and `pytest`. This is what GitHub Actions runs as
the `check` job; if it passes locally, CI passes. `pyright` (vanilla) is
NOT the same tool — `basedpyright` is stricter (catches `reportUnknownVariableType`,
`reportUnusedFunction`, etc.). Running `pyright` locally is a false-positive
green; always use `make check`.
- **Smoke a live search**: `flight search JFK LHR --dep 2026-08-15 --return 2026-08-22 -n 2`
- **API key**: resolved at runtime from Matrix's SPA bundle and cached at
`~/.cache/flight-cli/.matrix-key` (30-day TTL). Never hardcode keys in
source. Override via `FLIGHT_API_KEY` env var.
Expand Down
Loading