fix(converter): track v3.11.2 — render skill-rules.json from the staged dist#34
Merged
Conversation
…tree dist/ write_hooks(dist) received the staging directory but called render_hook_rules() without forwarding it, so the hook rules were derived from the committed dist/ manifest (the previous release) instead of the build in progress. Harmless when the staged and committed manifests match, but a cross-release bump emits skill-rules.json keyed to the old persona set, and validate.py rejects the orphaned personas. Surfaced converting upstream v3.11.2, which drops 7 agents relative to v3.8.4 (kieran python/rails/typescript, dhh-rails, schema-drift, data-migration-expert; data-migrations-reviewer -> data-migration-reviewer). - Forward `dist` through render_hook_rules so rules track the built manifest. - Add a regression test asserting write_hooks reads the manifest from the dir it is given. - Prune the 7 removed/renamed personas from persona-keywords.yaml and add Pass-B keywords for the new ce-data-migration-reviewer. - Correct the validate.py failure message (referenced a non-existent DEFAULT_HOOK_RULES; the real causes are stale overrides or an unthreaded dist).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the
publish-distfailure when converting upstream v3.11.2 (failed run).Root cause — a latent converter bug, not stale YAML
write_hooks(dist)received the staging dir but calledrender_hook_rules()without forwarding it, soskill-rules.jsonwas derived from the committeddist/manifest (the previous release) rather than the build in progress. Harmless when staged and committed manifests match — which is why it survived a year of same-release bumps — but a cross-release jump emitsskill-rules.jsonkeyed to the old persona set, andvalidate.pyrejects the orphans.v3.11.2 drops 7 agents vs v3.8.4:
ce-kieran-{python,rails,typescript}-reviewer,ce-dhh-rails-reviewer,ce-schema-drift-detector,ce-data-migration-expert; andce-data-migrations-reviewer→ce-data-migration-reviewer.Changes (converter-only;
dist/is regenerated bypublish-dist)distthroughrender_hook_rulesso hook rules track the built manifest.write_hooksmust read the manifest from the dir it's given (fails without the fix, leakingce-data-migration-expert— the exact CI symptom).persona-keywords.yaml; add Pass-B (claude -p) keywords for the newce-data-migration-reviewer.DEFAULT_HOOK_RULES; now names the real causes.Verification
nix flake check— all pass (format + actionlint + 165 pytest)validate.py --upstreaminto a clean staging dir (exact CI condition): passes for both v3.11.2 and v3.8.4After merge
Dispatch
publish-dist --field upstream_tag=compound-engineering-v3.11.2to open thedist/PR shipping3.11.2-lite.