Fix case-insensitive user email lookups#247
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR standardizes user-email handling to be case-insensitive across server flows, aiming to prevent authentication/user-lookup mismatches and block case-only duplicate emails at account creation.
Changes:
- Added shared email utilities (
normalizeEmail,userEmailEquals) for normalization and case-insensitive comparisons. - Updated multiple authenticated user lookups (middleware + banking/party/stocks/users server fns) to use the helper instead of case-sensitive or ad-hoc
lower(...)comparisons. - Normalized new user emails on insert and added a Vitest unit test for email normalization.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/middleware/auth.ts |
Updates activity-tracking user update to use case-insensitive email matching. |
src/lib/server/users.ts |
Normalizes stored emails on create and reuses helper for email-based lookups. |
src/lib/server/user-email.ts |
Introduces shared normalization and Drizzle WHERE helper for email equality. |
src/lib/server/user-email.test.ts |
Adds unit test covering trimming/lowercasing behavior of normalization. |
src/lib/server/stocks.ts |
Switches several authenticated user lookups to helper (but leaves one inline lower(...) lookup). |
src/lib/server/party.ts |
Switches party-related email lookups to helper. |
src/lib/server/banking.ts |
Switches bank balance lookup to helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Verification: