Improve PTP_SerializedEgraph serialization efficiency#70
Draft
FTRobbin wants to merge 20 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A breakdown of the serialized egraph shows that the frontend data structures produce a significant overhead (~40%) in the serialization size, which is about 20x the input file size.
The root of the problem is twofold: (1) the frontend data structures themselves are verbose because they are ASTs with lots of annotations; (2) our serialized representation is also bloated because of serde.
This PR has not addressed those two problems. However, under the assumption that only extractions are done at serve time,
egraph.rulesetsandegraph.overall_run_reportare not used and thus can be skipped during serialization/deserialization. On a few samples I tried locally, this reduces the overall size of the serialized egraph by ~25%.I'm putting up this PR to see how far this will get us.
A follow-up PR will add more size-related statistics to the nightly report so we can more easily see global improvements.