Skip to content
This repository was archived by the owner on Dec 25, 2025. It is now read-only.

Added support for shark europe devices#11

Open
TheLastFrame wants to merge 1 commit into
ajmarks:masterfrom
TheLastFrame:master
Open

Added support for shark europe devices#11
TheLastFrame wants to merge 1 commit into
ajmarks:masterfrom
TheLastFrame:master

Conversation

@TheLastFrame

@TheLastFrame TheLastFrame commented Jun 25, 2021

Copy link
Copy Markdown

Hi, due to shark European devices using different servers then shark US devices, I added support for the European servers.
I tested it with the Shark RV1000SEU

@captrik

captrik commented Jan 6, 2022

Copy link
Copy Markdown

Testet it with a Shark RV1100S1EU and can also confirm login works in EU

@creativeosmose

Copy link
Copy Markdown

@captrik great to hear!
I can't seem to make this branch work on HA, could you please give some indication on how you made it work ? (I assume that you did not use HACS)
Thanks!

@captrik

captrik commented Jan 19, 2022

Copy link
Copy Markdown

@captrik great to hear! I can't seem to make this branch work on HA, could you please give some indication on how you made it work ? (I assume that you did not use HACS) Thanks!

Hi, I testet it by manually running the PR version of this library with python (not the HA integration itself) as shown in the example in the Readme.

The HA integration (which just uses this package) will need some changes too in order to work with the "europe option"

@creativeosmose

Copy link
Copy Markdown

Hi, I testet it by manually running the PR version of this library with python (not the HA integration itself) as shown in the example in the Readme.

The HA integration (which just uses this package) will need some changes too in order to work with the "europe option"

I see, thanks.
By doing so, do you see it in HA? or is it only running independently?

@captrik

captrik commented Jan 19, 2022

Copy link
Copy Markdown

No this was completely independent from HA

@creativeosmose

Copy link
Copy Markdown

Understood, thanks for your quick feedback!

@TheLastFrame TheLastFrame mentioned this pull request Mar 28, 2022
@funkybunch

funkybunch commented Mar 30, 2022

Copy link
Copy Markdown

@TheLastFrame given the API endpoint woes we're seeing again this week, I suspect the EU URLs may need to be updated as well. There is a PR open on the Home Assistant repo to update the shark dependency to a fork of this repo that is actively maintained. Could you check the URLs & resubmit your PR on that repo so we can get it merged in? https://github.com/JeffResc/sharkiq/

Should be plug & play for the most part.

@TheLastFrame

Copy link
Copy Markdown
Author

Oh nice, that someone finally does what I always wanted to do.
I will look into it as soon as possible.

@funkybunch

Copy link
Copy Markdown

Closed in active fork repo via sharkiqlibs/sharkiq#16

@gtisi

gtisi commented Jan 9, 2023

Copy link
Copy Markdown

Hi was the EU feature all merged and completed please? I get the 'unexpected error' message but unsure if it is to do with the EU issue, or something else.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants