fix: do not prompt on non-interactive terminals#622
Merged
ajalt merged 1 commit intoJan 16, 2026
Merged
Conversation
Contributor
Author
|
Is there anything to be done to push this PR and #621 through? If it's just a matter of finding the time to review then I understand. |
Owner
|
Sorry for the delay. Since the changes are backwards incompatible, I've been waiting until I have time to make a major version release. |
Contributor
Author
Totally understandable. Just a heads up that #621 is backwards compatibility, so shouldn't require a major version release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #618
this has backwards compatibility concerns for library users' tests, as demonstrated by the need to alter this project's own existing tests. this could be considered fine as, if it is fixing incorrect behaviour, the existing test would be considered to be making incorrect assertions in the first place.