Skip to content

test(v2): match Arabic inspector steps by configured inspector name #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aix-ahmet merged 1 commit into from
Jul 21, 2026
Merged

test(v2): match Arabic inspector steps by configured inspector name #997

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tests/functional/v2/test_arabic_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,11 +171,12 @@ def _build_name(prefix: str, model_name: str) -> str:
return f"{prefix}-{model_name}-{int(time.time())}-{uuid.uuid4().hex[:6]}"


def _is_inspector_step(step: dict) -> bool:
def _is_inspector_step(step: dict, inspector_name: str = "") -> bool:
# The backend reports the inspector's own name as the step agent id
# (e.g. 'output_inspector_gpt_4o'), not an 'inspector|...' prefix.
# (e.g. 'ArabicContentValidator-gpt-4o'), not an 'inspector|...' prefix.
agent_info = step.get("agent") or {}
return "inspector" in (agent_info.get("id") or "").lower()
step_id = (agent_info.get("id") or "").lower()
return "inspector" in step_id or (bool(inspector_name) and step_id == inspector_name.lower())


def _is_inspector_abort_message(output: str) -> bool:
Expand Down Expand Up @@ -310,7 +311,7 @@ def test_arabic_inspector_agent_across_llms(client, resource_tracker, model_name

response = team_agent.run(ARABIC_QUERIES["pure_arabic"])
output, steps = _assert_success_response(response)
inspector_steps = [step for step in steps if _is_inspector_step(step)]
inspector_steps = [step for step in steps if _is_inspector_step(step, inspector.name)]
assert inspector_steps, "Expected inspector step(s) in the run"

if _is_inspector_abort_message(output):
Expand Down
Loading