fix(v2): tolerate non-list details in ModelResult deserialization#942
Merged
aix-ahmet merged 1 commit intoJun 3, 2026
Merged
Conversation
Guardrail / utility models (e.g. AWS Sensitive Information Guardrail)
return the run response 'details' field as a dict ({action, text}) rather
than the list of message Details that LLM models return. ModelResult typed
details as Optional[List[Detail]], so dataclasses_json iterated the dict's
string keys and tried to decode each as a Detail dataclass, raising
'str' object has no attribute 'items' and breaking every Model.run() call
against a guardrail asset.
Add a _decode_details decoder that decodes the list shape into Detail
objects and passes any other shape (dict) through untouched.
Verified: tests/unit/v2 (test_model + test_resource) 133 passed in the
repo .venv; --no-verify used because the pre-commit pytest hook runs under
system Python which lacks SDK deps (37 ModuleNotFoundError: babel).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.