Skip to content

Decode replies using actual received length #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aisk merged 1 commit into from
Jun 24, 2026
Merged

Decode replies using actual received length #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/ping.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,15 +132,15 @@ fn ping_with_socktype(
let reply = if dest.is_ipv4() {
// DGRAM socket on Linux may return pure ICMP packet without IP header.
if n == ECHO_REQUEST_BUFFER_SIZE {
match EchoReply::decode::<IcmpV4>(&buffer) {
match EchoReply::decode::<IcmpV4>(&buffer[..n]) {
Ok(reply) => reply,
Err(_) => continue,
}
} else {
// Skip undecodable IP packets (malformed, truncated, or
// unrelated ICMP traffic from other hosts on a RAW socket)
// instead of failing the whole ping; keep waiting for our reply.
let ipv4_packet = match IpV4Packet::decode(&buffer) {
let ipv4_packet = match IpV4Packet::decode(&buffer[..n]) {
Ok(packet) => packet,
Err(_) => continue,
};
Expand All @@ -151,7 +151,7 @@ fn ping_with_socktype(
}
}
} else {
match EchoReply::decode::<IcmpV6>(&buffer) {
match EchoReply::decode::<IcmpV6>(&buffer[..n]) {
Ok(reply) => reply,
Err(_) => continue,
}
Expand Down
Loading