Manifest generation: fail on write errors, clean up logging#394
Open
rossbacher wants to merge 1 commit into
Open
Manifest generation: fail on write errors, clean up logging#394rossbacher wants to merge 1 commit into
rossbacher wants to merge 1 commit into
Conversation
- ManifestGenerator: throw DeepLinkProcessorException on IOException instead of swallowing as a diagnostic warning (a missing manifest would otherwise fail silently in a confusing downstream place). Catch scoped to IOException so processor bugs aren't hidden. - RelocateDeepLinkManifestTask: use orNull instead of get() on the @optional kspManifestFile property (get() NPEs when unset), replace println with logger.warn, collapse empty else-if branch, fix typos. - GenerateManifestIntentFiltersForDeeplinkDispatchTask: replace println with logger.warn (respects --quiet) and switch error(...) calls to throw GradleException for idiomatic build-failure output.
441e49a to
39b066e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan