-
Notifications
You must be signed in to change notification settings - Fork 1
Api migration support UUIDs #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -10,13 +10,17 @@ import 'package:flutter_aira/src/models/feedback.dart'; | |||||||||||||||||
| class SessionFeedback { | ||||||||||||||||||
| SessionFeedback({ | ||||||||||||||||||
| required this.serviceId, | ||||||||||||||||||
| required this.serviceUuid, | ||||||||||||||||||
|
Comment on lines
12
to
+13
|
||||||||||||||||||
| required this.serviceId, | |
| required this.serviceUuid, | |
| this.serviceId, | |
| this.serviceUuid, |
Copilot
AI
Oct 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent capitalization in documentation comments. Line 59 starts with 'Please' (capitalized) while line 62 starts with 'please' (lowercase). Additionally, both comments should say 'does not exist' instead of 'not exist' for proper grammar.
| /// Please check the [serviceUuid] if [serviceId] not exist. | |
| int? serviceId; | |
| /// please check the [serviceId] if [serviceUuid] not exist. | |
| /// Please check the [serviceUuid] if [serviceId] does not exist. | |
| int? serviceId; | |
| /// Please check the [serviceId] if [serviceUuid] does not exist. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
uuidfield is marked as non-nullable and required inAccessOfferDetails, but existing API responses may not include this field. This could cause deserialization failures. Consider making this field nullable (String?) to handle cases where the UUID is not yet available.