3.3.4 and 3.3.5: Add resetDurationUsed and optInForMarketing fields#180
Merged
Conversation
Contributor
Author
|
I called it 3.3.4 because your PR 3.3.3 is not merged yet :D |
ming-chu
previously approved these changes
Sep 23, 2025
Comment on lines
+55
to
+56
| /// Will duration be reset. Values: "NEVER" or "UTC_MONTH" | ||
| final String resetDurationUsed; |
Contributor
There was a problem hiding this comment.
Nice, thanks to provide the doc comment! I am okay with the String type here for v1.
Let's consider other type later in the future if we have more types coming.
bwang-aira
changed the title
resetDurationUsed field to Profile (FE-42)resetDurationUsed and optInForMarketing fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
optInForMarketingfield to account creation (FE-23)resetDurationUsedfield toProfile(FE-42)