Expose livekit setting (FE-7)#179
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR exposes the LiveKit settings from the ServiceRequest by expanding the LiveKit class to include comprehensive configuration options. The change enables access to detailed LiveKit settings including global, microphone, screen share, and camera configurations.
- Adds a complete settings structure to the LiveKit class with all configuration options
- Provides comprehensive test coverage for the new settings classes and serialization
- Updates the package version to 3.3.3
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/src/livekit.dart | Expanded LiveKit class to include settings field and added multiple configuration classes for all LiveKit settings |
| test/livekit_test.dart | Added comprehensive test coverage for LiveKit settings serialization and validation |
| pubspec.yaml | Updated package version from 3.3.2 to 3.3.3 |
| CHANGELOG.md | Added changelog entry for version 3.3.3 |
| example/windows/flutter/generated_plugins.cmake | Removed unused plugin references |
| example/windows/flutter/generated_plugin_registrant.cc | Removed unused plugin registrations |
| example/macos/Flutter/GeneratedPluginRegistrant.swift | Removed unused plugin registrations |
| example/linux/flutter/generated_plugins.cmake | Removed unused plugin references |
| example/linux/flutter/generated_plugin_registrant.cc | Removed unused plugin registrations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
|
Those generated files under example are modified by Flutter which can be ignore during the review. |
bwang-aira
reviewed
Sep 23, 2025
bwang-aira
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but probably @kasemj's review would also be appreciated.
bwang-aira
previously approved these changes
Sep 23, 2025
bwang-aira
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.