Skip to content

Expose livekit setting (FE-7)#179

Merged
ming-chu merged 7 commits into
mainfrom
expose-livekit-setting
Sep 23, 2025
Merged

Expose livekit setting (FE-7)#179
ming-chu merged 7 commits into
mainfrom
expose-livekit-setting

Conversation

@ming-chu

Copy link
Copy Markdown
Contributor

No description provided.

@ming-chu ming-chu requested review from Copilot and kasemj September 10, 2025 15:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR exposes the LiveKit settings from the ServiceRequest by expanding the LiveKit class to include comprehensive configuration options. The change enables access to detailed LiveKit settings including global, microphone, screen share, and camera configurations.

  • Adds a complete settings structure to the LiveKit class with all configuration options
  • Provides comprehensive test coverage for the new settings classes and serialization
  • Updates the package version to 3.3.3

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
lib/src/livekit.dart Expanded LiveKit class to include settings field and added multiple configuration classes for all LiveKit settings
test/livekit_test.dart Added comprehensive test coverage for LiveKit settings serialization and validation
pubspec.yaml Updated package version from 3.3.2 to 3.3.3
CHANGELOG.md Added changelog entry for version 3.3.3
example/windows/flutter/generated_plugins.cmake Removed unused plugin references
example/windows/flutter/generated_plugin_registrant.cc Removed unused plugin registrations
example/macos/Flutter/GeneratedPluginRegistrant.swift Removed unused plugin registrations
example/linux/flutter/generated_plugins.cmake Removed unused plugin references
example/linux/flutter/generated_plugin_registrant.cc Removed unused plugin registrations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ming-chu ming-chu changed the title Expose livekit setting Expose livekit setting (FE-7) Sep 23, 2025
@ming-chu

Copy link
Copy Markdown
Contributor Author

Those generated files under example are modified by Flutter which can be ignore during the review.

@bwang-aira bwang-aira left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but probably @kasemj's review would also be appreciated.

@KasemJaffer KasemJaffer left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bwang-aira
bwang-aira previously approved these changes Sep 23, 2025
@ming-chu ming-chu merged commit c167848 into main Sep 23, 2025
1 check passed
@ming-chu ming-chu deleted the expose-livekit-setting branch September 23, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants