feat: adding trickle ice support#83
Open
rprata wants to merge 3 commits into
Open
Conversation
0e61553 to
aa5084f
Compare
Collaborator
|
Hi! Could you please drop all the changes not related to actual ICE trickle and rebase on top of main? |
2a5be00 to
49396bb
Compare
00141e5 to
80d3ffe
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
===========================================
- Coverage 100.00% 99.83% -0.17%
===========================================
Files 7 7
Lines 1232 1240 +8
===========================================
+ Hits 1232 1238 +6
- Misses 0 2 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
80d3ffe to
678caab
Compare
678caab to
b36da71
Compare
Collaborator
|
Hi @rprata ! I'm not sure I understand how this PR helps us: it does indeed "emit" candidates as it discovers them, but we're no closer to connecting while still gathering candidates. Unless I'm mistaken this is a much deeper change, because it means:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit enables Trickle ICE by allowing candidates to be exchanged incrementally between peers over the signaling channel.