Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions aiohttp/http_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -584,8 +584,11 @@ def parse_headers(
encoding = enc

# chunking
te = headers.get(hdrs.TRANSFER_ENCODING)
if te is not None:
te_values = headers.getall(hdrs.TRANSFER_ENCODING, ())
if te_values:
# RFC 9110 §5.3: Multiple header fields are equivalent to a single
# comma-separated value. Normalize before determining message framing.
te = ",".join(v.strip() for v in te_values)
if self._is_chunked_te(te):
chunked = True

Expand Down
19 changes: 19 additions & 0 deletions tests/test_http_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,25 @@ def test_duplicate_singleton_header_accepted_in_lax_mode(
assert len(messages) == 1


async def test_response_te_split_headers_chunked(
response: HttpResponseParser,
) -> None:
text = (
b"HTTP/1.1 200 OK\r\n"
b"Transfer-Encoding: gzip\r\n"
b"Transfer-Encoding: chunked\r\n"
b"\r\n"
b"4\r\nWiki\r\n0\r\n\r\n"
b"HTTP/1.1 204 No Content\r\n\r\n"
)
messages, upgrade, tail = response.feed_data(text)
assert len(messages) == 2
msg1, payload1 = messages[0]
assert msg1.chunked
assert await payload1.read() == b"Wiki"
assert messages[1][0].code == 204


def test_duplicate_host_header_rejected(parser: HttpRequestParser) -> None:
text = (
b"GET /admin HTTP/1.1\r\n"
Expand Down
Loading