Require basket name to ensure saved baskets are visible#232
Open
Metalicss wants to merge 1 commit into
Open
Conversation
When a logged-in user clicks the basket save icon, the basket is saved successfully. However, if no basket name is provided, the saved basket is not visible on the user account page. Requiring a basket name before saving would be the best solution
|
Coverage is 87.23% — Metalicss:patch-16 into aimeos:master. No base build found for |
Contributor
Author
|
This patch also affects other submit buttons, so it is not useful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a logged-in user clicks the basket save icon, the basket is saved successfully. However, if no basket name is provided, the saved basket is not visible on the user account page. Requiring a basket name before saving would be the best solution