Enhance service type validation and demand calculation - #177
Open
Eynor-K wants to merge 1 commit into
Open
Conversation
Eynor-K
commented
Jul 27, 2026
Eynor-K
commented
- Added validation in UnitsSchema to reject units with both site_area and build_floor_area set to zero.
- Modified demand calculation in Facade to use current candidate's demand instead of previous trial's state, preventing double-counting.
- Updated population demand calculation in ProvisionAdapter to include all residential blocks with new residents, ensuring accurate demand updates.
- Refactored optimizer initialization to allow customizable number of EI candidates for TPE trials.
- Added validation in UnitsSchema to reject units with both site_area and build_floor_area set to zero. - Modified demand calculation in Facade to use current candidate's demand instead of previous trial's state, preventing double-counting. - Updated population demand calculation in ProvisionAdapter to include all residential blocks with new residents, ensuring accurate demand updates. - Refactored optimizer initialization to allow customizable number of EI candidates for TPE trials.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.