fix: explicitly stop models to prevent concurrent loading errors - #37
Open
marcelrv wants to merge 2 commits into
Open
fix: explicitly stop models to prevent concurrent loading errors#37marcelrv wants to merge 2 commits into
marcelrv wants to merge 2 commits into
Conversation
Explicitly calls ollama stop after each run to ensure memory is freed. This prevents the benchmark from failing on systems where Ollama attempts to load multiple models simultaneously, which otherwise leads to resource exhaustion and prevents completion.
chuangtc
requested changes
Mar 10, 2026
chuangtc
left a comment
Member
There was a problem hiding this comment.
The fix is safe to merge if your ollama is reasonably recent (≥0.1.24). But it would be more robust with check=False or a try/except.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly calls ollama stop after each run to ensure memory is freed. This prevents the benchmark from failing on systems where Ollama attempts to load multiple models simultaneously, which otherwise leads to resource exhaustion and prevents completion.