[codex] support MCP subdir scans and explain hotspots#19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scan --explainroot reporting so subdirectory scans show both scan root and metadata root when they differ.Hotspotsoutput toscan --explain, grouping blocking findings by runtime/supply-chain concentration and rule.Impact
This makes narrowed MCP scans more conclusive for repos where the MCP server lives below the package root, and gives first-run users a clearer starting point when findings are concentrated in a few directories or rules.
Validation
cargo fmt --checkcargo clippy -- -D warningscargo test(262 passed)cargo test --all-features(337 passed)agentshield scan <tmp>/src/mcp --explain --fail-on highshowed scan root, metadata root, one parsed TypeScript file, and one tool.agentshield scan <tmp> --explain --fail-on highshowedHotspotswith runtime concentration inscripts/.Huly: AGENT-27 and AGENT-28 are marked Done.