🎨 Palette: Add contextual aria-labels to citation buttons#156
🎨 Palette: Add contextual aria-labels to citation buttons#156aicoder2009 wants to merge 1 commit into
Conversation
Added context-specific and dynamic `aria-label`s to generic visual text buttons like `[copy]`, `[edit]`, `[delete]`, and `[clear]` in the `SortableCitation` component to significantly improve screen reader accessibility. Ensures dynamic states (like `[copied!]`) are properly announced by making the labels reactive. Co-authored-by: aicoder2009 <127642633+aicoder2009@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR enhances the accessibility of the SortableCitation component by adding contextual ChangesSortableCitation Accessibility Labels
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎨 Palette: Add contextual aria-labels to citation buttons
💡 What: Added descriptive
aria-labelattributes to multiple action buttons (e.g., "[copy]", "[edit]", "[delete]", "[clear]") within theSortableCitationcomponent. Also updated dynamic state buttons to conditionally switch theiraria-label(e.g. "Citation copied!").🎯 Why: To improve accessibility. Because lists of citations often contain repetitive link/button texts (like "edit", "edit", "edit"), adding context (e.g., "Edit citation: Introduction to Web Accessibility") clarifies for screen reader users exactly which item the action applies to without relying on visual structure.
♿ Accessibility: Addressed WCAG guidelines regarding non-text context by providing contextual accessible names for generic text links and preserving dynamic screen reader feedback.
PR created automatically by Jules for task 5523942843128896863 started by @aicoder2009
Summary by CodeRabbit