chore: fix aidd-ui version and harden the release flow #370
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| name: Promote next to main | ||
|
|
||
| # One intuitive button to ship `next` to `main` the RIGHT way: a rebase-merge | ||
| # that preserves every conventional commit, so commitlint passes per commit and | ||
| # release-please reads the scopes to bump each plugin. A squash here collapses | ||
| # the commits into one (often non-conventional) message and breaks both, which | ||
| # is exactly the failure this workflow prevents. | ||
| # | ||
| # Run it from the Actions tab (Run workflow). It opens the next -> main PR and | ||
| # enables rebase auto-merge; CI gates it, then it merges itself. | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
|
|
||
| concurrency: | ||
| group: promote | ||
| cancel-in-progress: false | ||
|
|
||
| permissions: {} | ||
|
|
||
| jobs: | ||
| promote: | ||
| name: Open and rebase-merge next into main | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0 | ||
| id: app-token | ||
| with: | ||
| app-id: ${{ secrets.AIDD_BOT_APP_ID }} | ||
| private-key: ${{ secrets.AIDD_BOT_PRIVATE_KEY }} | ||
|
|
||
| - name: Open or reuse the promote PR, enable rebase auto-merge | ||
| env: | ||
| GH_TOKEN: ${{ steps.app-token.outputs.token }} | ||
| REPO: ${{ github.repository }} | ||
| run: | | ||
| set -euo pipefail | ||
| # Reuse an open next -> main PR if one exists, else open one with a | ||
| # conventional, squash-safe title. | ||
| PR=$(gh pr list --repo "$REPO" --base main --head next --state open --json number --jq '.[0].number' || true) | ||
| if [ -z "$PR" ]; then | ||
| PR=$(gh pr create --repo "$REPO" --base main --head next \ | ||
| --title "chore: promote next to main" \ | ||
| --body "Automated promotion of \`next\` to \`main\`. Merged by **rebase** to preserve conventional commits for release-please. Do not squash." \ | ||
| | grep -oE '[0-9]+$') | ||
| fi | ||
| echo "Promote PR: #$PR" | ||
| # Rebase auto-merge: GitHub merges it once CI is green. Never squash. | ||
| gh pr merge "$PR" --repo "$REPO" --rebase --auto | ||
|
There was a problem hiding this comment.
After a promote PR exists, this still asks GitHub to do a normal auto-merge. In the checked Useful? React with 👍 / 👎. |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| # Releasing | ||
|
|
||
| The release pipeline is automated. A human (or an AI agent) only triggers the | ||
| promotion; everything after that runs itself. | ||
|
|
||
| ## The flow | ||
|
|
||
| ``` | ||
| next --(promote)--> main --(release-please)--> version PR --(auto-merge)--> tags + GitHub releases | ||
| | | ||
| '--(back-merge)--> next (keeps next in sync) | ||
| ``` | ||
|
|
||
| 1. **Work lands on `next`** via normal PRs (rebase or squash into `next`, your choice). | ||
|
There was a problem hiding this comment.
This step says squashing PRs into Useful? React with 👍 / 👎. |
||
| 2. **Promote `next` to `main`.** Run the **Promote next to main** workflow (Actions tab -> Run workflow). It opens a `next -> main` PR and **rebase-merges** it. | ||
| 3. **release-please** runs on the push to `main`, opens a version PR (bumps + changelogs), and the CI **auto-merges that version PR** (`--squash --admin`). No human needed. | ||
| 4. **Tags and GitHub releases** are published per package and for the root. | ||
| 5. **Back-merge** fires on `release: published` and syncs `main` back into `next` so the changelog and version files do not drift. | ||
|
|
||
| ## The one rule: promote with REBASE, never squash | ||
|
|
||
| `next -> main` carries many conventional commits (`feat(scope):`, `fix(scope):`). | ||
| Two things depend on them: | ||
|
|
||
| - **commitlint** checks every commit message. A squash collapses them into one | ||
| subject taken from the PR title; if that title is not a valid conventional | ||
| type (e.g. `release:`), commitlint fails on `main` and **release-please is | ||
| skipped** -- no release happens. | ||
| - **release-please** reads each commit's type and scope to bump the right plugin | ||
| by the right amount. A squash hides them, so it cannot compute the versions. | ||
|
|
||
| So always use the **Promote** workflow (it rebase-merges). If you merge by hand, | ||
| use **Rebase and merge**, never **Squash**. The version PR that release-please | ||
| opens is its own single commit and is fine to squash -- that one is automated. | ||
|
|
||
| ## If a release breaks (recovery) | ||
|
|
||
| Symptom: after a promote, `main` CI is red on **Commitlint** and **Release | ||
| Please** is skipped -- usually a squashed, non-conventional promote commit. | ||
|
|
||
| 1. An admin temporarily disables the `main protection` ruleset (Settings -> | ||
| Rules), force-pushes `main` back to the commit before the bad merge, then | ||
| re-enables the ruleset. | ||
| 2. Re-run the **Promote** workflow (rebase). release-please then cuts the | ||
| release normally. | ||
|
|
||
| ## Pinning a specific version | ||
|
|
||
| To force a package to a chosen version on the next cut, set `release-as` for it | ||
| in `release-please-config.json` (deterministic, overrides any `Release-As:` | ||
| commit footer). Remove the pin afterwards so automatic bumps resume. | ||
|
|
||
| ## Back-merge failures | ||
|
|
||
| If the back-merge cannot push `next`, it opens an issue labelled | ||
| `back-merge-failed`. Resync by opening a `main -> next` PR. The root cause is the | ||
| bot app needing an `always` bypass on the `next` ruleset; align that and the | ||
| back-merge runs unattended. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1 @@ | ||
| # Changelog | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When there is no open
next -> mainPR yet, this assignment does not become empty:gh --jquses jq query syntax per the GitHub CLI formatting docs, andjq -r '.[0].number'on[]renders the literalnull. That makes[ -z "$PR" ]false, so the normal first run skipsgh pr createand then callsgh pr merge null, causing the new promote button to fail unless someone already opened the PR; use a fallback such as.[0].number // emptyor explicitly handlenull.Useful? React with 👍 / 👎.