Skip to content

feat(threads): add list org threads#28

Merged
rowan-stein merged 2 commits into
mainfrom
noa/issue-27
Apr 25, 2026
Merged

feat(threads): add list org threads#28
rowan-stein merged 2 commits into
mainfrom
noa/issue-27

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

Summary

  • implement ListOrganizationThreads filter/sort pagination with deterministic cursors
  • add nickname enrichment via Identity batch lookup
  • extend store query building and tests plus devspace buf paths

Testing

  • buf generate buf.build/agynio/api --path agynio/api/threads/v1 --path agynio/api/notifications/v1 --path agynio/api/identity/v1 --path agynio/api/metering/v1 --path agynio/api/agents/v1 --path agynio/api/authorization/v1
  • go vet ./...
  • go test ./...
  • go build ./...

Refs #27

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • buf generate buf.build/agynio/api --path agynio/api/threads/v1 --path agynio/api/notifications/v1 --path agynio/api/identity/v1 --path agynio/api/metering/v1 --path agynio/api/agents/v1 --path agynio/api/authorization/v1
  • go vet ./... (no issues)
  • go test ./... (passed: 3, failed: 0, skipped: 5 packages with no tests)
  • go build ./... (build ok)

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static review only (not running builds/tests).

Requesting changes:

  • Downstream Identity calls (ResolveNickname / BatchGetNicknames) are invoked with the server request context directly. In Go gRPC, incoming metadata is not forwarded automatically, so the Identity service won’t receive x-identity-id and will return Unauthenticated once auth is enforced. Please attach the identity header to the outgoing context (or add a small interceptor/helper), and add a unit assertion that outgoing metadata contains x-identity-id.

Everything else (filter/sort/pagination shape, deterministic secondary sort by id ASC, token includes filter+sort, store query builder + tests) looks aligned with the spec.

Comment thread internal/server/server.go Outdated
@casey-brooks
Copy link
Copy Markdown
Contributor Author

Summary

  • forward identity metadata into outgoing Identity RPC contexts
  • add tests asserting outgoing metadata for nickname resolution and batch lookup

Test & Lint Summary

  • buf generate buf.build/agynio/api --path agynio/api/threads/v1 --path agynio/api/notifications/v1 --path agynio/api/identity/v1 --path agynio/api/metering/v1 --path agynio/api/agents/v1 --path agynio/api/authorization/v1
  • go vet ./... (no issues)
  • go test ./... (passed: 3, failed: 0, skipped: 5 packages with no tests)
  • go build ./... (build ok)

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static re-review only (not running builds/tests).

Verified fix: Identity client calls now build an outgoing context (identityClientContext) that forwards x-identity-id (and related metadata when present), and tests assert outgoing metadata on both ResolveNickname and BatchGetNicknames.

@rowan-stein rowan-stein merged commit 5432594 into main Apr 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants