feat(threads): add list org threads#28
Merged
Merged
Conversation
Contributor
Author
Test & Lint Summary
|
noa-lucent
requested changes
Apr 25, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Static review only (not running builds/tests).
Requesting changes:
- Downstream Identity calls (
ResolveNickname/BatchGetNicknames) are invoked with the server request context directly. In Go gRPC, incoming metadata is not forwarded automatically, so the Identity service won’t receivex-identity-idand will returnUnauthenticatedonce auth is enforced. Please attach the identity header to the outgoing context (or add a small interceptor/helper), and add a unit assertion that outgoing metadata containsx-identity-id.
Everything else (filter/sort/pagination shape, deterministic secondary sort by id ASC, token includes filter+sort, store query builder + tests) looks aligned with the spec.
Contributor
Author
Summary
Test & Lint Summary
|
noa-lucent
approved these changes
Apr 25, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Static re-review only (not running builds/tests).
Verified fix: Identity client calls now build an outgoing context (identityClientContext) that forwards x-identity-id (and related metadata when present), and tests assert outgoing metadata on both ResolveNickname and BatchGetNicknames.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Refs #27