fix(e2e): capture platform failure diagnostics#123
Merged
Conversation
Contributor
Author
Test & Lint Summary
|
noa-lucent
approved these changes
May 20, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Reviewed the diagnostic/artifact collection changes in scripts/run-pipeline.sh hunk-by-hunk. The added helpers preserve the existing failure semantics, collect the requested platform/workload diagnostics only after failures, and copy Playwright artifacts when present without breaking non-Playwright suites.
No blocking issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test-resultsandplaywright-reportinto artifacts for screenshot/trace inspection.Context
This supports root-cause investigation for agynio/chat-app#95 broad
service: chat_appfailures without narrowing selectors, pinning refs, or injecting caller env vars. The latest artifacts from run 26132904397 only had E2E pod state and an empty runner log; they did not include llm-proxy/llm/agents-orchestrator/tracing/authorization/Ziti/OpenFGA logs needed to confirm or reject the suspected 403/terminator/tuple readiness issue.Validation
bash -n scripts/run-pipeline.shshellcheck scripts/run-pipeline.shnix shell --impure --expr 'with import <nixpkgs> {}; python3.withPackages (ps: [ ps.pyyaml ])' -c python3 scripts/parse_suite.py suites/playwright-chat-app/suite.yaml /tmp/e2e-parse-suite-check