Skip to content

feat: add agent availability roles#97

Merged
rowan-stein merged 3 commits into
mainfrom
noa/issue-51
May 13, 2026
Merged

feat: add agent availability roles#97
rowan-stein merged 3 commits into
mainfrom
noa/issue-51

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

Summary

Validation

  • See the tracking issue and PR comments for repo-specific test/lint results.

Closes agynio/agents#51

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • npm run lint
    • Linting passed with no errors or warnings.
  • npm run typecheck
    • Typecheck passed with no errors.
  • npm run test
    • Blocked locally by Node/Vitest runtime crash: Bus error before tests ran; test stats unavailable (0 passed / 0 failed / 0 skipped reported).
  • npm run build
    • Blocked locally by Vite runtime crash: Bus error before build output.

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Updated Test & Lint Summary

Root cause: the local crash was caused by running the console app with Node v24.14.1. The repo CI uses Node 20, and running locally with Nix Node 20 resolves the Bus error. I added .nvmrc and engines.node = 20.x to make the required runtime explicit.

Validated with:

  • nix shell nixpkgs#nodejs_20 -c sh -c 'npm ci && npm run lint && npm run typecheck && npm run test && npm run build'
    • Linting passed with no errors or warnings.
    • Typecheck passed with no errors.
    • Test stats: 66 passed, 0 failed, 0 skipped across 17 test files.
    • Build passed; Vite emitted only the existing large chunk warning.

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the UI work. I found a blocking issue: the branch currently fails typecheck because the generated API contract in this repo does not include the new agent availability/role types or RPCs. I also left one formatting cleanup comment. Requesting changes before merge.

Comment thread src/lib/format.ts
Comment thread src/pages/AgentCreatePage.tsx Outdated
@casey-brooks
Copy link
Copy Markdown
Contributor Author

Addressed Noa's requested changes:

  • Updated buf.gen.yaml to generate from the API feature branch contract until the API module publishes the new contract.
  • Committed the generated agents/gateway API contract files required by the branch typecheck.
  • Fixed the JSX formatting in AgentCreatePage.tsx.
  • Confirmed local build/test under Node 20 to avoid the Node 24 Bus error seen locally.

Validation:

  • nix shell nixpkgs#nodejs_20 -c sh -c 'npm ci && npm run generate && npm run lint && npm run typecheck && npm run test && npm run build' passed.
  • Tests: 66 passed, 0 failed, 0 skipped across 17 test files.
  • Lint status: npm run lint passed with no errors.
  • Typecheck/build status: npm run typecheck and npm run build passed.

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review complete. The generated API types now include the new availability/role contract, build/typecheck/test are passing in CI, and the create-agent form formatting is cleaned up. Approved.

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refreshed at head 3cdacd4. The prior typecheck/API generation and formatting issues remain resolved; build/typecheck/test are passing. Approved.

@rowan-stein rowan-stein merged commit 339da2b into main May 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement agent availability and per-agent roles

3 participants