Skip to content

ci: add dedicated E2E workflow#105

Merged
rowan-stein merged 2 commits into
mainfrom
noa/e2e-workflow-badge
May 23, 2026
Merged

ci: add dedicated E2E workflow#105
rowan-stein merged 2 commits into
mainfrom
noa/e2e-workflow-badge

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

Summary

  • Adds a dedicated .github/workflows/e2e.yml for the existing console-app E2E job.
  • Removes the E2E job from .github/workflows/ci.yml so CI and E2E have separate workflow badge targets.
  • Preserves the current provisioning, generated types, build, deploy, and service settings.

Closes #104

Test & Lint Summary

Commands run:

npm ci
npm run generate
npm run lint
npm run typecheck
npm test
npm run build
git diff --check
actionlint .github/workflows/ci.yml .github/workflows/e2e.yml

Results:

  • Vitest: 79 passed; 0 failed; 0 skipped.
  • ESLint: passed with no errors.
  • TypeScript typecheck: passed.
  • Production build: passed.
  • Workflow linting: passed with no errors.
  • Whitespace validation: passed.

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

Commands run:

npm ci
npm run generate
npm run lint
npm run typecheck
npm test
npm run build
git diff --check
actionlint .github/workflows/ci.yml .github/workflows/e2e.yml

Results:

  • Vitest: 79 passed; 0 failed; 0 skipped.
  • ESLint: passed with no errors.
  • TypeScript typecheck: passed.
  • Production build: passed.
  • Workflow linting: passed with no errors.
  • Whitespace validation: passed.

noa-lucent
noa-lucent previously approved these changes May 23, 2026
Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The existing console E2E job has been moved into a dedicated workflow without changing its service-specific provisioning, generation, build, deploy, or test behavior.

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Follow-up: E2E scope fix

Investigated failing run 26335775201 / job e2e. The split workflow was invoking agynio/e2e/.github/actions/run-tests@main with only:

service: console

The action defaults include_smoke to true, so it expanded tags to svc_console smoke. That selected unrelated smoke coverage from go-core and playwright-tracing-app, which produced the highlighted failures:

  • go-core TestWorkloadStartsOnUnackedMessage
  • playwright-tracing-app smoke test message deep link empty state

Pushed 2b4594c to this same branch to add:

include_smoke: false

This keeps the dedicated workflow focused on console-tagged E2E coverage and prevents unrelated smoke suites from running under the console-app badge workflow.

Test & Lint Summary

Commands run:

git diff --check
actionlint .github/workflows/ci.yml .github/workflows/e2e.yml
npm run lint
npm run typecheck
npm test
npm run build

Results:

  • Vitest: 79 passed; 0 failed; 0 skipped.
  • ESLint: passed with no errors.
  • TypeScript typecheck: passed.
  • Production build: passed.
  • Workflow linting: passed with no errors.
  • Whitespace validation: passed.

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed after commit 2b4594c. The E2E workflow now passes include_smoke: false for the console service, matching the intended limited E2E scope while preserving the dedicated workflow split. CI and E2E are green.

@rowan-stein rowan-stein merged commit 14085cd into main May 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add dedicated E2E workflow for README badge

3 participants