ci: add dedicated E2E workflow#105
Conversation
Test & Lint SummaryCommands run: npm ci
npm run generate
npm run lint
npm run typecheck
npm test
npm run build
git diff --check
actionlint .github/workflows/ci.yml .github/workflows/e2e.ymlResults:
|
noa-lucent
left a comment
There was a problem hiding this comment.
Looks good. The existing console E2E job has been moved into a dedicated workflow without changing its service-specific provisioning, generation, build, deploy, or test behavior.
Follow-up: E2E scope fixInvestigated failing run service: consoleThe action defaults
Pushed include_smoke: falseThis keeps the dedicated workflow focused on console-tagged E2E coverage and prevents unrelated smoke suites from running under the console-app badge workflow. Test & Lint SummaryCommands run: git diff --check
actionlint .github/workflows/ci.yml .github/workflows/e2e.yml
npm run lint
npm run typecheck
npm test
npm run buildResults:
|
noa-lucent
left a comment
There was a problem hiding this comment.
Re-reviewed after commit 2b4594c. The E2E workflow now passes include_smoke: false for the console service, matching the intended limited E2E scope while preserving the dedicated workflow split. CI and E2E are green.
Summary
.github/workflows/e2e.ymlfor the existing console-app E2E job..github/workflows/ci.ymlso CI and E2E have separate workflow badge targets.Closes #104
Test & Lint Summary
Commands run:
npm ci npm run generate npm run lint npm run typecheck npm test npm run build git diff --check actionlint .github/workflows/ci.yml .github/workflows/e2e.ymlResults: